Date: Thu, 21 Sep 2017 22:47:43 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Stefan =?iso-8859-1?Q?Br=FCns?= <stefan.bruens@rwth-aachen.de>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] dmaengine: edma: Reject slave configs using a buswidth
 of 8 and larger
Message-ID: <20170921171743.GI30097@localhost>
References: <20170917142510.3111-1-stefan.bruens@rwth-aachen.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170917142510.3111-1-stefan.bruens@rwth-aachen.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 956
Lines: 33

On Sun, Sep 17, 2017 at 04:25:10PM +0200, Stefan Br?ns wrote:
> The driver would happily accept buswidth of 16/32/64 bytes and program
> garbage to its registers.

Peter?

> 
> Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>
> ---
>  drivers/dma/edma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 3879f80a4815..c944ea339425 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -887,8 +887,8 @@ static int edma_slave_config(struct dma_chan *chan,
>  {
>  	struct edma_chan *echan = to_edma_chan(chan);
>  
> -	if (cfg->src_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES ||
> -	    cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
> +	if (cfg->src_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES ||
> +	    cfg->dst_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES)
>  		return -EINVAL;
>  
>  	memcpy(&echan->cfg, cfg, sizeof(echan->cfg));
> -- 
> 2.14.1
> 

-- 
~Vinod