Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbdIUUNb (ORCPT ); Thu, 21 Sep 2017 16:13:31 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37545 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbdIUUN3 (ORCPT ); Thu, 21 Sep 2017 16:13:29 -0400 X-Google-Smtp-Source: AOwi7QCUAAKFcR2mgSkEbsjZWAWedGN1msgqKSTTsGBumwyq8/Nj+wxAKCZyvKe44W7lRZoLxFvGp2HqZPoFlfczq+E= MIME-Version: 1.0 In-Reply-To: <20170912121016.GF2908@pathway.suse.cz> References: <1504729681-3504-1-git-send-email-deller@gmx.de> <1504729681-3504-3-git-send-email-deller@gmx.de> <20170912121016.GF2908@pathway.suse.cz> From: Richard Weinberger Date: Thu, 21 Sep 2017 22:13:27 +0200 Message-ID: Subject: Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses To: Petr Mladek Cc: Helge Deller , LKML , Sergey Senozhatsky , Andrew Morton , Jeff Dike , Richard Weinberger , "user-mode-linux-devel@lists.sourceforge.net" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 36 On Tue, Sep 12, 2017 at 2:10 PM, Petr Mladek wrote: > On Wed 2017-09-06 22:27:49, Helge Deller wrote: >> Use the %pS printk format for printing symbols from direct addresses. >> In usermode-linux there is actually no difference between %pS and %pF, but for >> consistency throughout the kernel fix the wrong usage here too. >> >> Signed-off-by: Helge Deller >> Cc: Jeff Dike >> Cc: Richard Weinberger >> Cc: user-mode-linux-devel@lists.sourceforge.net >> --- >> arch/um/kernel/sysrq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c >> index 6b995e8..05585ee 100644 >> --- a/arch/um/kernel/sysrq.c >> +++ b/arch/um/kernel/sysrq.c >> @@ -20,7 +20,7 @@ >> >> static void _print_addr(void *data, unsigned long address, int reliable) >> { >> - pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ", >> + pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ", >> (void *)address); > > This seems to be used to print addresses from the stack. > IMHO, we should use %pB here. %pWTF? ;) Agreed, let's use %pB. -- Thanks, //richard