Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbdIVFrT (ORCPT ); Fri, 22 Sep 2017 01:47:19 -0400 Received: from mga11.intel.com ([192.55.52.93]:19784 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdIVFrR (ORCPT ); Fri, 22 Sep 2017 01:47:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="1222230873" Date: Fri, 22 Sep 2017 08:47:12 +0300 From: Mika Westerberg To: Kyle Roeschley Cc: heikki.krogerus@linux.intel.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe Message-ID: <20170922054712.GW4630@lahna.fi.intel.com> References: <20170921192003.17324-1-kyle.roeschley@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170921192003.17324-1-kyle.roeschley@ni.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 458 Lines: 9 On Thu, Sep 21, 2017 at 02:20:03PM -0500, Kyle Roeschley wrote: > Powering off the system on Apollo Lake does not clear the interrupt > enable registers for the GPIOs. To avoid an interrupt storm on driver > probe, clear all interrupt enables before enabling our interrupt line. It is up to the BIOS to set the proper mask and program the pads accordingly. Which platform and BIOS this is? I would rather not do this because it might cause other problems.