Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdIVGz3 (ORCPT ); Fri, 22 Sep 2017 02:55:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:49512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdIVGz1 (ORCPT ); Fri, 22 Sep 2017 02:55:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E9B22A72 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Fri, 22 Sep 2017 14:54:56 +0800 From: Shawn Guo To: yinbo.zhu@nxp.com Cc: Rob Herring , Mark Rutland , "Catalin Marinas )" , "Will Deacon )" , Harninder Rai , Raghav Dogra , Ashish Kumar , Yuantian Tang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, open list Subject: Re: [PATCH v2] arm64: dts: ls1088a: Add USB support Message-ID: <20170922065454.GF26358@dragon> References: <20170913091009.21448-1-yinbo.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913091009.21448-1-yinbo.zhu@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2143 Lines: 77 On Wed, Sep 13, 2017 at 05:10:09PM +0800, yinbo.zhu@nxp.com wrote: > From: "yinbo.zhu" > > Fix the issue that usb is not detected on ls1088ardb It's not really about fixing issue but adding support. > > Signed-off-by: yinbo.zhu > Signed-off-by: Ran Wang > --- You should better have a version history here to tell what's changed between version. > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 20 ++++++++++++++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index 213abb72de93..6c3c3bc4b681 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -118,6 +118,14 @@ > status = "okay"; > }; > > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > + > &esdhc { Please sort these labeled nodes alphabetically. Shawn > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index c144d06a6e33..c23fede8cf5d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -359,6 +359,26 @@ > status = "disabled"; > }; > > + usb0: usb3@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 IRQ_TYPE_LEVEL_HIGH>; > + dr_mode = "host"; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,dis_rxdet_inp3_quirk; > + status = "disabled"; > + }; > + > + usb1: usb3@3110000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>; > + dr_mode = "host"; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,dis_rxdet_inp3_quirk; > + status = "disabled"; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1088a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 2.14.1 >