From: Marc Zyngier <marc.zyngier@arm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tglx@linutronix.de, jason@lakedaemon.net, vz@mleia.com,
        slemieux.tyco@gmail.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf
In-Reply-To: <1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>
        (Arvind Yadav's message of "Wed, 20 Sep 2017 13:38:18 +0530")
Organization: ARM Ltd
References: <1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
Date: Fri, 22 Sep 2017 09:10:41 +0100
Message-ID: <86vakbnofy.fsf@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 485
Lines: 15

On Wed, Sep 20 2017 at  1:38:18 pm BST, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> kasprintf() can fail here and we must check its return value.

Or not. The use of these strings is purely cosmetic (they are only used
to display various debug information), and printk is perfectly able to
handle a NULL string.

Refusing to probe an essential piece of HW because a debug feature
failed seems at best counter-productive.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.