Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbdIVI6D (ORCPT ); Fri, 22 Sep 2017 04:58:03 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36702 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751810AbdIVI6C (ORCPT ); Fri, 22 Sep 2017 04:58:02 -0400 X-Google-Smtp-Source: AOwi7QCSh75qcWufOkOFJaRCAhZ6lw4jhDimSi1cg3AB/joypYM3+SJjVRgPlrczFrz/u63mk5JSWg== Subject: Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf To: Marc Zyngier References: <1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com> <86vakbnofy.fsf@arm.com> Cc: tglx@linutronix.de, jason@lakedaemon.net, vz@mleia.com, slemieux.tyco@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Arvind Yadav Message-ID: Date: Fri, 22 Sep 2017 14:27:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <86vakbnofy.fsf@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 575 Lines: 16 Hi Marc, On Friday 22 September 2017 01:40 PM, Marc Zyngier wrote: > On Wed, Sep 20 2017 at 1:38:18 pm BST, Arvind Yadav wrote: >> kasprintf() can fail here and we must check its return value. > Or not. The use of these strings is purely cosmetic (they are only used > to display various debug information), and printk is perfectly able to > handle a NULL string. > > Refusing to probe an essential piece of HW because a debug feature > failed seems at best counter-productive. Yes, Your are right. Sorry for noise. :) > Thanks, > > M. ~arvind