Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdIVJDS (ORCPT ); Fri, 22 Sep 2017 05:03:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56234 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdIVJDP (ORCPT ); Fri, 22 Sep 2017 05:03:15 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5C0B1C058EB4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Fri, 22 Sep 2017 11:03:12 +0200 From: Jiri Olsa To: yuzhoujian Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com, arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer Message-ID: <20170922090312.GE15856@krava> References: <1505714122-39141-1-git-send-email-yuzhoujian@didichuxing.com> <1505714122-39141-3-git-send-email-yuzhoujian@didichuxing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505714122-39141-3-git-send-email-yuzhoujian@didichuxing.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 22 Sep 2017 09:03:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 30 On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote: SNIP > out_put: > addr_location__put(&al); > @@ -1605,6 +1617,7 @@ static int process_comm_event(struct perf_tool *tool, > struct perf_session *session = script->session; > struct perf_evsel *evsel = perf_evlist__id2evsel(session->evlist, sample->id); > int ret = -1; > + FILE *fp; > > thread = machine__findnew_thread(machine, event->comm.pid, event->comm.tid); > if (thread == NULL) { > @@ -1621,8 +1634,9 @@ static int process_comm_event(struct perf_tool *tool, > sample->tid = event->comm.tid; > sample->pid = event->comm.pid; > } > - print_sample_start(sample, thread, evsel); > - perf_event__fprintf(event, stdout); > + fp = stdout; > + fprint_sample_start(sample, thread, evsel, fp); > + perf_event__fprintf(event, fp); please make this simple 'adding fp argument to print functions' change and just pass stdout in here ... and do the rest of changes later on thanks, jirka