Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbdIVJD0 (ORCPT ); Fri, 22 Sep 2017 05:03:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdIVJDX (ORCPT ); Fri, 22 Sep 2017 05:03:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 033D45F798 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Fri, 22 Sep 2017 11:03:19 +0200 From: Jiri Olsa To: yuzhoujian Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com, arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer Message-ID: <20170922090319.GF15856@krava> References: <1505714122-39141-1-git-send-email-yuzhoujian@didichuxing.com> <1505714122-39141-3-git-send-email-yuzhoujian@didichuxing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505714122-39141-3-git-send-email-yuzhoujian@didichuxing.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 22 Sep 2017 09:03:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 24 On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote: > Signed-off-by: yuzhoujian > --- > tools/perf/builtin-script.c | 247 ++++++++++++++++++++++++-------------------- > 1 file changed, 136 insertions(+), 111 deletions(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 91b5225..f709f6f 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -486,8 +486,8 @@ static int perf_session__check_output_opt(struct perf_session *session) > return 0; > } > > -static void print_sample_iregs(struct perf_sample *sample, > - struct perf_event_attr *attr) > +static void fprint_sample_iregs(struct perf_sample *sample, > + struct perf_event_attr *attr, FILE *fp) please make sure the perf gets compiled after every change, I think this will break compile because of unused *fp, use the __maybe_unused attribute jirka