Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751921AbdIVJNf (ORCPT ); Fri, 22 Sep 2017 05:13:35 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:48962 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdIVJNe (ORCPT ); Fri, 22 Sep 2017 05:13:34 -0400 Subject: Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options To: Suman Anna CC: Bartosz Golaszewski , David Lechner , , References: <20170920180132.4373-1-s-anna@ti.com> <758ebb8d-cdf5-4cdc-253b-b1eb8e2f7c61@ti.com> <52fd708b-8497-8d5d-262b-f78ecf068d87@ti.com> From: Sekhar Nori Message-ID: Date: Fri, 22 Sep 2017 14:42:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <52fd708b-8497-8d5d-262b-f78ecf068d87@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 33 Hi Suman, On Thursday 21 September 2017 08:41 PM, Suman Anna wrote: > On 09/21/2017 09:43 AM, Sekhar Nori wrote: >> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote: >>> Enable the CMA and DMA_CMA Kconfig options by default for >>> Davinci platforms. Davinci remoteproc driver is one of the >>> modules that depends on these options, and this allows the >>> driver to be made visible for selection with menuconfig. >>> >>> Signed-off-by: Suman Anna >>> --- >>> Hi Sekhar, >>> >>> Here's the patch that enables CMA as per your request. Patch based >>> on your v4.15/defconfig branch. >> >> Applied! I guess you will be sending another patch enabling the >> remoteproc driver itself? > > Thanks. Well, one always needs a firmware image in their filesystem > without which enabling the driver is meaningless (it would fail). So was > not planning to enable it by default. But the errors will show up only on DA850 LCDK where we have enabled the DSP by default in DT because its an important usecase there. I think it is important for users to see those errors. (besides the usual benefits of having the module enabled to catch build and runtime issues easily). Thanks, Sekhar