Date: Fri, 22 Sep 2017 14:40:22 +0200
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] sched: Cleanup task->state printing
Message-ID: <20170922124022.GA234@x4>
References: <20170910073653.GA284@x4>
 <20170911131128.GD1774378@devbig577.frc2.facebook.com>
 <20170911142133.GA2265@x4>
 <20170921110842.GA4020@x4>
 <20170921123000.bip2whks53bwn7de@hirez.programming.kicks-ass.net>
 <20170921144127.GA236@x4>
 <20170922093533.GA235@x4>
 <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 670
Lines: 19

On 2017.09.22 at 13:54 +0200, Peter Zijlstra wrote:
> On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote:
> > > It seems to work. Simply returning "I (idle)" from get_task_state() in
> > > fs/proc/array.c when the state is TASK_IDLE does the trick.
> > > I've tested top, htop and ps.
> 
> I ended up with the below; there was quite a lot of inconsistent state
> printing around it seems.
> 
> I should probably split this thing into a bunch of patches :/
> 
> Alongside an explicit idle state, this also exposes TASK_PARKED,
> although arguably we could map that to idle too. Opinions?

Looks good to me and works as expected.
Many thanks.

-- 
Markus