Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbdIVNOp (ORCPT ); Fri, 22 Sep 2017 09:14:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:55523 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751909AbdIVNOn (ORCPT ); Fri, 22 Sep 2017 09:14:43 -0400 Date: Fri, 22 Sep 2017 15:14:38 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, clm@fb.com, jack@suse.cz Subject: Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode Message-ID: <20170922131438.GB22455@quack2.suse.cz> References: <1505921582-26709-1-git-send-email-axboe@kernel.dk> <1505921582-26709-5-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505921582-26709-5-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 23 On Wed 20-09-17 09:32:59, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our own. This changes the writeback to not be range cyclic, > but that should not matter for laptop mode flush-all > semantics. > > Acked-by: Johannes Weiner > Tested-by: Chris Mason > Signed-off-by: Jens Axboe > Reviewed-by: Jan Kara > Signed-off-by: Jens Axboe The subject of the patch looks stale. Honza -- Jan Kara SUSE Labs, CR