Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbdIVNjJ (ORCPT ); Fri, 22 Sep 2017 09:39:09 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:48519 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdIVNjH (ORCPT ); Fri, 22 Sep 2017 09:39:07 -0400 X-Google-Smtp-Source: AOwi7QBZpdvkcK4fPQjVOIHOkYOA0WEU4YA+PyfA8gPe8OsszLAkVNGVGhF5fOibOuwJ3KrN9tVkEmE6ywOrt1IPPOg= MIME-Version: 1.0 In-Reply-To: <20170922054712.GW4630@lahna.fi.intel.com> References: <20170921192003.17324-1-kyle.roeschley@ni.com> <20170922054712.GW4630@lahna.fi.intel.com> From: Linus Walleij Date: Fri, 22 Sep 2017 15:39:06 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe To: Mika Westerberg Cc: Kyle Roeschley , Heikki Krogerus , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 18 On Fri, Sep 22, 2017 at 7:47 AM, Mika Westerberg wrote: > On Thu, Sep 21, 2017 at 02:20:03PM -0500, Kyle Roeschley wrote: >> Powering off the system on Apollo Lake does not clear the interrupt >> enable registers for the GPIOs. To avoid an interrupt storm on driver >> probe, clear all interrupt enables before enabling our interrupt line. > > It is up to the BIOS to set the proper mask and program the pads > accordingly. Which platform and BIOS this is? > > I would rather not do this because it might cause other problems. If this needs to happen llike this on some systems or even just on some BIOS revisions the target systems and/or BIOS revisions certainly need to be detected first. Yours, Linus Walleij