Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbdIVOMp (ORCPT ); Fri, 22 Sep 2017 10:12:45 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57902 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdIVOMo (ORCPT ); Fri, 22 Sep 2017 10:12:44 -0400 Date: Fri, 22 Sep 2017 15:12:40 +0100 From: Catalin Marinas To: Will Deacon Cc: Arvind Yadav , mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf Message-ID: <20170922141240.n7spqo6rxzfzb42d@armageddon.cambridge.arm.com> References: <20170922105405.GD23365@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170922105405.GD23365@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 33 On Fri, Sep 22, 2017 at 11:54:06AM +0100, Will Deacon wrote: > On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote: > > Free memory region, if arm_pmu_acpi_probe is not successful. > > > > Signed-off-by: Arvind Yadav > > --- > > drivers/perf/arm_pmu_acpi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c > > index 0a9b787..3303dd8 100644 > > --- a/drivers/perf/arm_pmu_acpi.c > > +++ b/drivers/perf/arm_pmu_acpi.c > > @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn) > > ret = armpmu_register(pmu); > > if (ret) { > > pr_warn("Failed to register PMU for CPU%d\n", cpu); > > + kfree(pmu->name); > > return ret; > > } > > } > > It's a bit weird that we bail out of the loop on the first failing CPU, but > you've not changed that behaviour so your patch looks fine in isolation: > > Acked-by: Will Deacon > > Catalin: can you pick this up as a fix, please? Applied. Thanks. -- Catalin