Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752539AbdIVOMv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 10:12:51 -0400
Received: from mail.kernel.org ([198.145.29.99]:35790 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752518AbdIVOMt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 10:12:49 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8B923B1B
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 22 Sep 2017 10:12:45 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
        Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] sched: Cleanup task->state printing
Message-ID: <20170922101245.05a26514@gandalf.local.home>
In-Reply-To: <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
References: <20170910073653.GA284@x4>
        <20170911131128.GD1774378@devbig577.frc2.facebook.com>
        <20170911142133.GA2265@x4>
        <20170921110842.GA4020@x4>
        <20170921123000.bip2whks53bwn7de@hirez.programming.kicks-ass.net>
        <20170921144127.GA236@x4>
        <20170922093533.GA235@x4>
        <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 984
Lines: 37

On Fri, 22 Sep 2017 13:54:30 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> I should probably split this thing into a bunch of patches :/

Yes please. Convert form dec to hex in one patch and one patch only.

Because I'm not sure if you meant to change numbers or not.


>  /* Used in tsk->state again: */
> -#define TASK_DEAD			64
> -#define TASK_WAKEKILL			128
> -#define TASK_WAKING			256
> -#define TASK_PARKED			512
> -#define TASK_NOLOAD			1024
> -#define TASK_NEW			2048
> -#define TASK_STATE_MAX			4096
> +#define TASK_PARKED			0x0040
> +#define TASK_REPORT_MAX			0x0080
>  
> -#define TASK_STATE_TO_CHAR_STR		"RSDTtXZxKWPNn"
> +/* Not in TASK_REPORT: */
> +#define TASK_DEAD			0x0080

TASK_DEAD went from 64 to 128 (0x40 to 0x80)

As well as all the defines below that. Was this on purpose?

> +#define TASK_WAKEKILL			0x0100
> +#define TASK_WAKING			0x0200
> +#define TASK_NOLOAD			0x0400
> +#define TASK_NEW			0x0800
> +
> +#define TASK_STATE_MAX			0x1000

-- Steve