Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbdIVPvS (ORCPT ); Fri, 22 Sep 2017 11:51:18 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:45924 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbdIVPvR (ORCPT ); Fri, 22 Sep 2017 11:51:17 -0400 X-Google-Smtp-Source: AOwi7QA0vZ+gD/PfARwJT4RCPe7mQo9hNblcFjALD3fAzsidvmZLdqPhPat3y9mdtwS+MnrceC1iTg== Subject: Re: [PATCH] selftests: timers: set-timer-lat: Fix hang when testing unsupported alarms To: Shuah Khan , john.stultz@linaro.org, tglx@linutronix.de, sboyd@codeaurora.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20170921194510.16305-1-shuahkh@osg.samsung.com> <8378e236-a46d-835d-639f-87963158695f@osg.samsung.com> From: Greg Hackmann Message-ID: <61d7ab12-f7e5-97aa-258a-30b56e906d7e@google.com> Date: Fri, 22 Sep 2017 08:51:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8378e236-a46d-835d-639f-87963158695f@osg.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 480 Lines: 12 On 09/22/2017 07:41 AM, Shuah Khan wrote: > I assume you are good with this fix. I plan to apply it to linux-kselftest fixes > today. Please let me know if you have any objections. > > thanks, > -- Shuah > AIUI this check was added so set-timer-lat would treat a missing CAP_WAKE_ALARM as a skipped test (rather than making the entire test fail). So setup_timer()'s callers would need to treat this as a special case, by returning immediately but with a return value of 0.