Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752509AbdIVP4x (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 11:56:53 -0400
Received: from merlin.infradead.org ([205.233.59.134]:51694 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752087AbdIVP4v (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 11:56:51 -0400
Date: Fri, 22 Sep 2017 17:56:40 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
        Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] sched: Cleanup task->state printing
Message-ID: <20170922155640.hkugqbd7x6w6tsxu@hirez.programming.kicks-ass.net>
References: <20170910073653.GA284@x4>
 <20170911131128.GD1774378@devbig577.frc2.facebook.com>
 <20170911142133.GA2265@x4>
 <20170921110842.GA4020@x4>
 <20170921123000.bip2whks53bwn7de@hirez.programming.kicks-ass.net>
 <20170921144127.GA236@x4>
 <20170922093533.GA235@x4>
 <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
 <20170922101245.05a26514@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170922101245.05a26514@gandalf.local.home>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1099
Lines: 34

On Fri, Sep 22, 2017 at 10:12:45AM -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 13:54:30 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > I should probably split this thing into a bunch of patches :/
> 
> Yes please. Convert form dec to hex in one patch and one patch only.

Yeah, was already on it, did more cleanups too.

> Because I'm not sure if you meant to change numbers or not.
> 
> 
> >  /* Used in tsk->state again: */
> > -#define TASK_DEAD			64
> > -#define TASK_WAKEKILL			128
> > -#define TASK_WAKING			256
> > -#define TASK_PARKED			512
> > -#define TASK_NOLOAD			1024
> > -#define TASK_NEW			2048
> > -#define TASK_STATE_MAX			4096
> > +#define TASK_PARKED			0x0040
> > +#define TASK_REPORT_MAX			0x0080
> >  
> > -#define TASK_STATE_TO_CHAR_STR		"RSDTtXZxKWPNn"
> > +/* Not in TASK_REPORT: */
> > +#define TASK_DEAD			0x0080
> 
> TASK_DEAD went from 64 to 128 (0x40 to 0x80)
> 
> As well as all the defines below that. Was this on purpose?

Yes, was on purpose. I moved TASK_PARKED up, such that I could include
it in the TASK_REPORT mask and keep that contiguous.