Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbdIVQLo (ORCPT ); Fri, 22 Sep 2017 12:11:44 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:36124 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdIVQLl (ORCPT ); Fri, 22 Sep 2017 12:11:41 -0400 X-Google-Smtp-Source: AOwi7QBdjZY7WHVw5u46yhY7N7KOTQugWa53OBON5H+a62tfkAFqUfhleV7c2Lq/lvsR12qo0/0evDFyUqBp5mcUNLo= MIME-Version: 1.0 In-Reply-To: <6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com> References: <1504520928-5191-1-git-send-email-divagar.mohandass@intel.com> <1504520928-5191-3-git-send-email-divagar.mohandass@intel.com> <6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com> From: Andy Shevchenko Date: Fri, 22 Sep 2017 19:11:40 +0300 Message-ID: Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size" To: "Mani, Rajmohan" Cc: "Mohandass, Divagar" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "wsa@the-dreams.de" , "sakari.ailus@iki.fi" , "devicetree@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tfiga@chromium.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 55 On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan wrote: > Adding Tomasz... Please, don't top post. Better to resend entire series with all stakeholders included. >> Obtain the size of the EEPROM chip from DT if the "size" property is specified >> for the device. >> I guess it lacks Suggested-by: Andy Shevchenko Other than that, looks good to me! Reviewed-by: Andy Shevchenko Wolfram, the binding is ACKed by Rob and this one is in a good shape. Moreover, it seems like a demand for the property since some IoT stuff would like to use the driver on ACPI enabled platforms with different sizes. Can you go ahead and apply first two patches? It would be really appreciated. >> Signed-off-by: Divagar Mohandass >> --- >> drivers/misc/eeprom/at24.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index >> 764ff5df..2199c42 100644 >> --- a/drivers/misc/eeprom/at24.c >> +++ b/drivers/misc/eeprom/at24.c >> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct >> at24_platform_data *chip) >> if (device_property_present(dev, "read-only")) >> chip->flags |= AT24_FLAG_READONLY; >> >> + err = device_property_read_u32(dev, "size", &val); >> + if (!err) >> + chip->byte_len = val; >> + >> err = device_property_read_u32(dev, "pagesize", &val); >> if (!err) { >> chip->page_size = val; >> -- >> 1.9.1 > -- With Best Regards, Andy Shevchenko