Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbdIVQeV (ORCPT ); Fri, 22 Sep 2017 12:34:21 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52616 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbdIVQeS (ORCPT ); Fri, 22 Sep 2017 12:34:18 -0400 Date: Fri, 22 Sep 2017 18:34:16 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to open Message-ID: <20170922163416.GB3470@lunn.ch> References: <20170922161753.19563-1-vivien.didelot@savoirfairelinux.com> <20170922161753.19563-4-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170922161753.19563-4-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 522 Lines: 14 On Fri, Sep 22, 2017 at 12:17:52PM -0400, Vivien Didelot wrote: > The DSA slave open function configures the unicast MAC addresses on the > master device, enable the switch port, change its STP state, then start > the PHY device. > > Make the close function symmetric, by first stopping the PHY device, > then changing the STP state, disabling the switch port and restore the > master device. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew