Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbdIVQnd (ORCPT ); Fri, 22 Sep 2017 12:43:33 -0400 Received: from vern.gendns.com ([206.190.152.46]:42310 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbdIVQnc (ORCPT ); Fri, 22 Sep 2017 12:43:32 -0400 Subject: Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options To: Suman Anna , Sekhar Nori Cc: Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170920180132.4373-1-s-anna@ti.com> <758ebb8d-cdf5-4cdc-253b-b1eb8e2f7c61@ti.com> <52fd708b-8497-8d5d-262b-f78ecf068d87@ti.com> <158a7e84-dd66-e861-544d-172b2d3723ec@ti.com> From: David Lechner Message-ID: Date: Fri, 22 Sep 2017 11:43:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <158a7e84-dd66-e861-544d-172b2d3723ec@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1779 Lines: 44 On 09/22/2017 11:24 AM, Suman Anna wrote: > Hi Sekhar, > >> >> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote: >>> On 09/21/2017 09:43 AM, Sekhar Nori wrote: >>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote: >>>>> Enable the CMA and DMA_CMA Kconfig options by default for >>>>> Davinci platforms. Davinci remoteproc driver is one of the >>>>> modules that depends on these options, and this allows the >>>>> driver to be made visible for selection with menuconfig. >>>>> >>>>> Signed-off-by: Suman Anna >>>>> --- >>>>> Hi Sekhar, >>>>> >>>>> Here's the patch that enables CMA as per your request. Patch based >>>>> on your v4.15/defconfig branch. >>>> >>>> Applied! I guess you will be sending another patch enabling the >>>> remoteproc driver itself? >>> >>> Thanks. Well, one always needs a firmware image in their filesystem >>> without which enabling the driver is meaningless (it would fail). So was >>> not planning to enable it by default. >> >> But the errors will show up only on DA850 LCDK where we have enabled the >> DSP by default in DT because its an important usecase there. I think it >> is important for users to see those errors. >> (besides the usual benefits of having the module enabled to catch build >> and runtime issues easily). > > Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported > boards, but I believe there are boards still using legacy boot, and it > shows up on those platforms as well. FYI, we do not have any rpmsg > drivers other than the kernel sample to make real usage of a booted > remoteproc. Anycase, if you still prefer this to be added, I don't mind. > > regards > Suman > I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement I2C and UART in the PRU.