Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbdIVQvs (ORCPT ); Fri, 22 Sep 2017 12:51:48 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:48504 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbdIVQvq (ORCPT ); Fri, 22 Sep 2017 12:51:46 -0400 X-Google-Smtp-Source: AOwi7QBJMkjreZJabb/ch6VUmmBFQRicbu6S7kQIVVTYwvE/abfRyNqibsrHp10WZgMXJMOOF/mqBA== Subject: Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size To: Colin King , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170922140316.12768-1-colin.king@canonical.com> From: Arend van Spriel Message-ID: <96caf646-a43c-9b78-a4a9-2becf7e74125@broadcom.com> Date: Fri, 22 Sep 2017 18:51:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170922140316.12768-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 38 Please use 'brcmsmac:' as prefix instead of 'brcm80211:'. On 22-09-17 16:03, Colin King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: > text data bss dec hex filename > 39482 564 0 40046 9c6e phy_cmn.o > > After > text data bss dec hex filename > 39326 620 0 39946 9c0a phy_cmn.o > > (gcc 6.3.0, x86-64) Acked-by: Arend van Spriel > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c > index 1c4e9dd57960..3a13d176b221 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c > @@ -1916,7 +1916,7 @@ void wlc_phy_txpower_update_shm(struct brcms_phy *pi) > pi->hwpwr_txcur); > > for (j = TXP_FIRST_OFDM; j <= TXP_LAST_OFDM; j++) { > - const u8 ucode_ofdm_rates[] = { > + static const u8 ucode_ofdm_rates[] = { > 0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c > }; > offset = wlapi_bmac_rate_shm_offset( >