Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbdIVRP0 (ORCPT ); Fri, 22 Sep 2017 13:15:26 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:48455 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbdIVRPZ (ORCPT ); Fri, 22 Sep 2017 13:15:25 -0400 X-Google-Smtp-Source: AOwi7QDc0/hpItZcTIY+wNOVWqFhiTe6z0al3A6+YASq0iAwkK+HZZE+74ll1G5uQbjEh+cPLpSvhA== Subject: Re: [PATCH net-next 3/4] net: dsa: make slave close symmetrical to open To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20170922161753.19563-1-vivien.didelot@savoirfairelinux.com> <20170922161753.19563-4-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <4bab03d6-40e8-1009-8f70-e39baab908f5@gmail.com> Date: Fri, 22 Sep 2017 10:15:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170922161753.19563-4-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 14 On 09/22/2017 09:17 AM, Vivien Didelot wrote: > The DSA slave open function configures the unicast MAC addresses on the > master device, enable the switch port, change its STP state, then start > the PHY device. > > Make the close function symmetric, by first stopping the PHY device, > then changing the STP state, disabling the switch port and restore the > master device. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian