Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbdIVTLK (ORCPT ); Fri, 22 Sep 2017 15:11:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52816 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbdIVTLJ (ORCPT ); Fri, 22 Sep 2017 15:11:09 -0400 Date: Fri, 22 Sep 2017 21:11:05 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" Subject: Re: [PATCH net-next 2/4] net: dsa: remove phy arg from port enable/disable Message-ID: <20170922191105.GF3470@lunn.ch> References: <20170922161753.19563-1-vivien.didelot@savoirfairelinux.com> <20170922161753.19563-3-vivien.didelot@savoirfairelinux.com> <87377eob5t.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <6d7799bb-2b33-0696-1805-63cea5e52667@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d7799bb-2b33-0696-1805-63cea5e52667@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 309 Lines: 8 > Historical reasons mostly. Considering the complexity of > dsa_slave_phy_setup(), I would certainly be extremely careful in > changing any of this, the potential for breakage is pretty big. Yes, i took a look at this, wondering how to convert to phylink. I went away and got a stiff drink :-) Andrew