Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbdIVUOL (ORCPT ); Fri, 22 Sep 2017 16:14:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50090 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752004AbdIVUOG (ORCPT ); Fri, 22 Sep 2017 16:14:06 -0400 From: Reza Arbab To: Andrew Morton Cc: Michal Hocko , Jan Kara , Ross Zwisler , "Kirill A. Shutemov" , Lorenzo Stoakes , Dave Jiang , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Matthew Wilcox , Hugh Dickins , Huang Ying , Ingo Molnar , "Aneesh Kumar K.V" , James Morse , Naoya Horiguchi , Minchan Kim , Johannes Weiner , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/device-public-memory: Enable move_pages() to stat device memory Date: Fri, 22 Sep 2017 15:13:56 -0500 X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17092220-0008-0000-0000-00000284AF50 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007779; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000231; SDB=6.00920859; UDB=6.00462755; IPR=6.00701080; BA=6.00005601; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017251; XFM=3.00000015; UTC=2017-09-22 20:14:03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17092220-0009-0000-0000-000036C9AFC5 Message-Id: <1506111236-28975-1-git-send-email-arbab@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-22_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709220280 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2004 Lines: 56 The move_pages() syscall can be used to find the numa node where a page currently resides. This is not working for device public memory pages, which erroneously report -EFAULT (unmapped or zero page). Enable by adding a FOLL_DEVICE flag for follow_page(), which move_pages() will use. This could be done unconditionally, but adding a flag seems like a safer change. Cc: Jérôme Glisse Signed-off-by: Reza Arbab --- include/linux/mm.h | 1 + mm/gup.c | 2 +- mm/migrate.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index f8c10d3..783cb57 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2368,6 +2368,7 @@ static inline struct page *follow_page(struct vm_area_struct *vma, #define FOLL_MLOCK 0x1000 /* lock present pages */ #define FOLL_REMOTE 0x2000 /* we are working on non-current tsk/mm */ #define FOLL_COW 0x4000 /* internal GUP flag */ +#define FOLL_DEVICE 0x8000 /* return device pages */ static inline int vm_fault_to_errno(int vm_fault, int foll_flags) { diff --git a/mm/gup.c b/mm/gup.c index b2b4d42..6fbad70 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -110,7 +110,7 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, return NULL; } - page = vm_normal_page(vma, address, pte); + page = _vm_normal_page(vma, address, pte, flags & FOLL_DEVICE); if (!page && pte_devmap(pte) && (flags & FOLL_GET)) { /* * Only return device mapping pages in the FOLL_GET case since diff --git a/mm/migrate.c b/mm/migrate.c index 6954c14..dea0ceb 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1690,7 +1690,7 @@ static void do_pages_stat_array(struct mm_struct *mm, unsigned long nr_pages, goto set_status; /* FOLL_DUMP to ignore special (like zero) pages */ - page = follow_page(vma, addr, FOLL_DUMP); + page = follow_page(vma, addr, FOLL_DUMP | FOLL_DEVICE); err = PTR_ERR(page); if (IS_ERR(page)) -- 1.8.3.1