Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbdIVU1g (ORCPT ); Fri, 22 Sep 2017 16:27:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50730 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbdIVU1e (ORCPT ); Fri, 22 Sep 2017 16:27:34 -0400 Date: Fri, 22 Sep 2017 23:27:14 +0300 From: Dan Carpenter To: Arvind Yadav Cc: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: greybus: light: Release memory obtained by kasprintf Message-ID: <20170922202714.ex7y34hhydjqjg5e@mwanda> References: <33458cb8d9a1b20752517fe7c6ada21c13069fc6.1506056972.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33458cb8d9a1b20752517fe7c6ada21c13069fc6.1506056972.git.arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 279 Lines: 8 On Fri, Sep 22, 2017 at 10:49:43AM +0530, Arvind Yadav wrote: > - Free memory region, if gb_lights_channel_config is not successful. > - No need to add check for gb_lights_channel_flash_config(). These should be separate patches. They're not related. regards, dan carpenter