Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbdIWDkr (ORCPT ); Fri, 22 Sep 2017 23:40:47 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59280 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbdIWDkq (ORCPT ); Fri, 22 Sep 2017 23:40:46 -0400 Date: Fri, 22 Sep 2017 20:40:45 -0700 (PDT) Message-Id: <20170922.204045.1198472539959809091.davem@davemloft.net> To: josef@toxicpanda.com Cc: netdev@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] fix reuseaddr regression From: David Miller In-Reply-To: <1506126008-9148-1-git-send-email-josef@toxicpanda.com> References: <1506126008-9148-1-git-send-email-josef@toxicpanda.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Sep 2017 20:40:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 13 From: Josef Bacik Date: Fri, 22 Sep 2017 20:20:05 -0400 > I introduced a regression when reworking the fastreuse port stuff that allows > bind conflicts to occur once a reuseaddr successfully opens on an existing tb. > The root cause is I reversed an if statement which caused us to set the tb as if > there were no owners on the socket if there were, which obviously is not > correct. > > Dave could you please queue these changes up for -stable, I've run them through > the net tests and added another test to check for this problem specifically. Series applied and queued up for -stable, thanks.