Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbdIWAUY (ORCPT ); Fri, 22 Sep 2017 20:20:24 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35221 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbdIWAUU (ORCPT ); Fri, 22 Sep 2017 20:20:20 -0400 X-Google-Smtp-Source: AOwi7QB7VFm61n+ABjfD3Mv5U2qR+kNyzxMYe/dfDmP/wHmOk9P7XA7gPtFP8wqeqQ1Rzu6xPp0PHg== From: Josef Bacik To: davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Cc: Josef Bacik Subject: [PATCH 2/3] net: use inet6_rcv_saddr to compare sockets Date: Fri, 22 Sep 2017 20:20:07 -0400 Message-Id: <1506126008-9148-3-git-send-email-josef@toxicpanda.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1506126008-9148-1-git-send-email-josef@toxicpanda.com> References: <1506126008-9148-1-git-send-email-josef@toxicpanda.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 From: Josef Bacik In ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the ipv6 compare with the fast socket information to make sure we're doing the proper comparisons. Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a reuseport sk") Reported-and-tested-by: Cole Robinson Signed-off-by: Josef Bacik --- net/ipv4/inet_connection_sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index f87f4805e244..a1bf30438bc5 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -266,7 +266,7 @@ static inline int sk_reuseport_match(struct inet_bind_bucket *tb, #if IS_ENABLED(CONFIG_IPV6) if (tb->fast_sk_family == AF_INET6) return ipv6_rcv_saddr_equal(&tb->fast_v6_rcv_saddr, - &sk->sk_v6_rcv_saddr, + inet6_rcv_saddr(sk), tb->fast_rcv_saddr, sk->sk_rcv_saddr, tb->fast_ipv6_only, -- 2.7.4