Date: Sat, 23 Sep 2017 18:15:54 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Aishwarya Pant <aishpant@gmail.com>,
        Phil Elwell <phil@raspberrypi.org>, Eric Anholt <eric@anholt.net>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption
Message-ID: <20170923161554.GA13023@kroah.com>
References: <1502446827-86427-1-git-send-email-phil@raspberrypi.org>
 <1488620757.209623.1506164253450@email.1und1.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1488620757.209623.1506164253450@email.1und1.de>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 917
Lines: 24

On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> Hi Greg,
> 
> > Phil Elwell <phil@raspberrypi.org> hat am 11. August 2017 um 12:20 geschrieben:
> > 
> > 
> > The previous commit (0adbfd46) fixed a memory leak but also freed a
> > block in the success case, causing a stale pointer to be used with
> > potentially fatal results. Only free the vchi_instance block in the
> > case that vchi_connect fails; once connected, the instance is
> > retained for subsequent connections.
> > 
> > Simplifying the code by removing a bunch of gotos and returning errors
> > directly.
> > 
> > Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()")
> 
> can you still apply this patch or do you need a resend?

Hm, I don't see this anywhere in my tree, or in my todo mbox, so yes,
please resend it, thanks.

greg k-h