Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbdIWQRw (ORCPT ); Sat, 23 Sep 2017 12:17:52 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:37408 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdIWQRu (ORCPT ); Sat, 23 Sep 2017 12:17:50 -0400 X-Google-Smtp-Source: AOwi7QDiPzhY/lDMYkwOASid+rxRgA0zskEn0vC67idqFkt2QjJgJHQi0OmYqPlDSWGneUF/YascD7KdGC+0JUBYH6c= MIME-Version: 1.0 Reply-To: rajatxjain@gmail.com In-Reply-To: References: <20170920223152.100641-1-rajatja@google.com> <2747669.9xpxs90BZc@aspire.rjw.lan> From: Rajat Jain Date: Sat, 23 Sep 2017 09:17:48 -0700 Message-ID: Subject: Re: [PATCH 1/2] i2c: designware: switch to suspend_late/resume_early To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Rajat Jain , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Wolfram Sang , linux-i2c , Linux Kernel Mailing List , Lee Jones , "Wysocki, Rafael J" , Linux PM , Len Brown , Furquan Shaikh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2692 Lines: 60 On Sat, Sep 23, 2017 at 8:49 AM, Rajat Jain wrote: > On Sat, Sep 23, 2017 at 5:55 AM, Rafael J. Wysocki wrote: >> On Thu, Sep 21, 2017 at 4:11 PM, Rafael J. Wysocki wrote: >>> On Thursday, September 21, 2017 3:13:56 AM CEST Rajat Jain wrote: >>>> On Wed, Sep 20, 2017 at 5:24 PM, Rafael J. Wysocki wrote: >>>> > On Thu, Sep 21, 2017 at 12:31 AM, Rajat Jain wrote: >>>> >> Ref: https://lkml.org/lkml/2017/9/19/649 >>>> >> >>>> >> The bus controllers should suspend the bus operations only after >>>> >> all of the devices on the bus have suspended their device >>>> >> completely. Since the i2c_client drivers could be talking to >>>> >> their devices in their suspend_late() calls, lets ensure that the >>>> >> bus is alive by that time. Thus moving the controller suspend logic to >>>> >> suspend_late(). >>>> >> >>>> >> Signed-off-by: Rajat Jain >>>> >> --- >>>> >> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- >>>> >> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >> >>>> >> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c >>>> >> index 0e65b97842b4..66dd7f844c40 100644 >>>> >> --- a/drivers/i2c/busses/i2c-designware-platdrv.c >>>> >> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c >>>> >> @@ -468,7 +468,7 @@ static int dw_i2c_plat_suspend(struct device *dev) >>>> >> static const struct dev_pm_ops dw_i2c_dev_pm_ops = { >>>> >> .prepare = dw_i2c_plat_prepare, >>>> >> .complete = dw_i2c_plat_complete, >>>> >> - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) >>>> >> + SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) >>>> >> SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, >>>> >> dw_i2c_plat_resume, >>>> >> NULL) >>>> > >>>> > No, you can't just do that. >>>> > >>>> > I sent patches to do it properly before my trip to LA last week, it >>>> > shouldn't be overly difficult to find them in the mailing list >>>> > archives. I can look them up tomorrow if need be. >>>> >>>> Thanks, I am guessing you mean this? >>>> >>>> https://patchwork.kernel.org/patch/9939807/ >>> >>> Yes, that's what I mean. >> >> BTW, does this patchset work for you? > > Yes, I don't see the issue I was seeing earlier with your patch. > Please feel free to adds, I think I made my sentence ambiguous. Let me rephrase: Yes, with your patch, I don't see the issue I was seeing earlier (without your patch) > > Tested-by: Rajat Jain > >> >> Thanks, >> Rafael