Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdIWQ57 (ORCPT ); Sat, 23 Sep 2017 12:57:59 -0400 Received: from zm-mta-out-2.u-ga.fr ([152.77.200.57]:35491 "EHLO zm-mta-out-2.u-ga.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdIWQ55 (ORCPT ); Sat, 23 Sep 2017 12:57:57 -0400 X-Greylist: delayed 506 seconds by postgrey-1.27 at vger.kernel.org; Sat, 23 Sep 2017 12:57:57 EDT Reply-To: nicolas.palix@univ-grenoble-alpes.fr Subject: Re: [PATCH] coccicheck: improve pattern for getting relative path To: Cihangir Akturk , Julia.Lawall@lip6.fr Cc: Gilles.Muller@lip6.fr, mmarek@suse.com, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <1502386825-363-1-git-send-email-cakturk@gmail.com> From: "Nicolas Palix (LIG)" Organization: UJF Polytech / LIG Erods Message-ID: <84d90a7d-899f-e6af-8f3c-cde69f5d1396@imag.fr> Date: Sat, 23 Sep 2017 18:49:29 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1502386825-363-1-git-send-email-cakturk@gmail.com> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms050004020300000103070207" X-Greylist: Whitelist-UJF SMTP Authentifie (palixn@univ-grenoble-alpes.fr) via smtps.univ-grenoble-alpes.fr ACL (97) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6280 Lines: 127 This is a cryptographically signed message in MIME format. --------------ms050004020300000103070207 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable Le 10/08/17 =C3=A0 19:40, Cihangir Akturk a =C3=A9crit=C2=A0: > When invoked with V=3D1, coccicheck script prints the information about= > which semantic patch (*.cocci file) used for this operation. Actually,= > it prints out the relative path of the related semantic patch. The > script uses sed to remove the source tree part from cocci file path lik= e > so: >=20 > FILE=3D`echo $COCCI | sed "s|$srctree/||"` >=20 > This pattern works well most of the time. But in cases where $COCCI > doesn't start with "./" characters, it doesn't remove the right part. >=20 > Consider the following scenario: >=20 > $ make coccicheck COCCI=3Dscripts/coccinelle/api/drm-get-put.cocci \ > MODE=3Dpatch M=3Ddrivers/staging V=3D1 >=20 > where >=20 > COCCI=3Dscripts/coccinelle/api/drm-get-put.cocci and srctree=3D. >=20 > In this case, out pattern matches the first "s/", and we end up > assigning "scriptcoccinelle/api/drm-get-put.cocci" to $FILE. >=20 > Fix this by adding a caret ^ at the beginning of regex pattern, so that= > it matches only start of the path. >=20 > Signed-off-by: Cihangir Akturk Acked-by: nicolas.palix@univ-grenoble-alpes.fr > --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/scripts/coccicheck b/scripts/coccicheck > index ec487b8..8de4245 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -193,7 +193,7 @@ coccinelle () { > =20 > if [ $VERBOSE -ne 0 -a $ONLINE -eq 0 ] ; then > =20 > - FILE=3D`echo $COCCI | sed "s|$srctree/||"` > + FILE=3D`echo $COCCI | sed "s|^$srctree/||"` > =20 > echo "Processing `basename $COCCI`" > echo "with option(s) \"$OPT\"" >=20 --=20 Nicolas Palix http://lig-membres.imag.fr/palix/ --------------ms050004020300000103070207 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: Signature cryptographique S/MIME MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC CG8wggO2MIICnqADAgECAgEDMA0GCSqGSIb3DQEBBQUAMCwxCzAJBgNVBAYTAkZSMQ0wCwYD VQQKEwRDTlJTMQ4wDAYDVQQDEwVDTlJTMjAeFw0wOTAxMjEwOTAzNTJaFw0yOTAxMjAwOTAz NTJaMDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJTMRcwFQYDVQQDEw5DTlJTMi1TdGFu ZGFyZDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAJypZGq0ByMZw74ICMTiKl3t 1Cje/j+g7ZJEaxZHNRM3jXSp9U2D5AUbjwhhTN53W9ep/7tlncmsPA/xiXuTIqBHD18Gvo54 oAt510JlYXJjkkCKW2cQ+tYnPth3TR55229LEgBSWOLYQgWyMzd34I1sHbz49vKUWCX3gtmG 2Vzz2C7N/XCJBIfvOdEq2JKMaS8cUmX6YI8Qf8yP+VwuFO1Mi+CdN7jSPJTKUP1Bet72POyu 7L1cFt2w8HOZeoH/OzPSAJ5NjMZbOC4zw3aGynJU2y3iEP2SUGiThO13qYlpUYXr4JSj+ZcI EYwk8A+6OLQs1tdsTmP+tDGf74+mWqUCAwEAAaOB2TCB1jAPBgNVHRMBAf8EBTADAQH/MB0G A1UdDgQWBBQR49nRUkcbWbE8G3hma/ShiO0KWzBUBgNVHSMETTBLgBRQl7YN96wzF6/xHUY8 azv/AKDl5aEwpC4wLDELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxDjAMBgNVBAMTBUNO UlMyggEAMA4GA1UdDwEB/wQEAwIBBjA+BgNVHR8ENzA1MDOgMaAvhi1odHRwOi8vY3Jscy5z ZXJ2aWNlcy5jbnJzLmZyL0NOUlMyL2dldGRlci5jcmwwDQYJKoZIhvcNAQEFBQADggEBAE/p 4xfmTCf1F2pQVeruz0yqve4s3XY+WaAvC2iJ2kPQHh0saxL5ZxOeZSukhNIxz4Kgyu8i6BBs 6c8XfKyth4VMiuHVe0zm2Q6yoeQpniCvDz57uX8kTDLgiP562qwWYKF1romcimadlLp+qw4g I+33x4RdgkgU3sTUsMVOLIfUjQMRLzbVKW+umWcZDI1tWiDf0Z/Gy69V7gvKsVsP71x09PNG iWNHfizOv8gwDQBG9hjmbD8wfpBuEI0fOUnPk2nryJ7CZ3OvSov2fEIo3aXd7a/JVRtkP1S8 YSYQ65HV6ffu0PYLC/qmkN1g9ECdC6ec+M4vITj+qwa/2g13+mcwggSxMIIDmaADAgECAgMA sYYwDQYJKoZIhvcNAQEFBQAwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNV BAMTDkNOUlMyLVN0YW5kYXJkMB4XDTE2MDMzMTE0MzczN1oXDTE4MDMzMTE0MzczN1owbDEL MAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxEDAOBgNVBAsTB1VNUjUyMTcxFjAUBgNVBAMT DU5pY29sYXMgUGFsaXgxJDAiBgkqhkiG9w0BCQEWFU5pY29sYXMuUGFsaXhAaW1hZy5mcjCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOrXeKVCpb7MjlNJjUttPdthNS7GvU/h TZezIPCzuM73eHIpYNVx0qVsnP6fTzAc+7i7a/hAcTM2XChLkm+tzpbWJ44CNoQ9+OCgMW+3 6sRS1Kv66bz1qKqxj4hXnWoGga/ND4bbMmtS0tG+LZ0jpqk5p2K01DU12XnmQ5zi5O+eV0i1 ERLJkJd+m9duJOCa9tni/b05Lcs2LClfYFrmr1cMvGPmy0UguRYrlWjQrMKddLLmMgo8cv4n GebpUfcgo3WmOz4BxKjNzj551Quy2QVtg3gYvuUEtNW88ONofmJ3+wr++ialKRPZM0C1MaCN c6HJ//GVMWldxs0dQLrqUs8CAwEAAaOCAZEwggGNMAwGA1UdEwEB/wQCMAAwEQYJYIZIAYb4 QgEBBAQDAgSwMA4GA1UdDwEB/wQEAwIF4DB6BglghkgBhvhCAQ0EbRZrQ2VydGlmaWNhdCBD TlJTMi1TdGFuZGFyZC4gUG91ciB0b3V0ZSBpbmZvcm1hdGlvbiBzZSByZXBvcnRlciDgIGh0 dHA6Ly9pZ2Muc2VydmljZXMuY25ycy5mci9DTlJTMi1TdGFuZGFyZC8wHQYDVR0OBBYEFLd6 +Ifph9Z/6Ky//jQzMhNtCru7MFQGA1UdIwRNMEuAFBHj2dFSRxtZsTwbeGZr9KGI7QpboTCk LjAsMQswCQYDVQQGEwJGUjENMAsGA1UEChMEQ05SUzEOMAwGA1UEAxMFQ05SUzKCAQMwIAYD VR0RBBkwF4EVTmljb2xhcy5QYWxpeEBpbWFnLmZyMEcGA1UdHwRAMD4wPKA6oDiGNmh0dHA6 Ly9jcmxzLnNlcnZpY2VzLmNucnMuZnIvQ05SUzItU3RhbmRhcmQvZ2V0ZGVyLmNybDANBgkq hkiG9w0BAQUFAAOCAQEAhowl+iLEKBtHY1ygh+luUrBwA/a0PnqnR4Ih92ywgJZ+8yawSpuw p3pqgXAi0WVqWN5fIYZII954W4XwUAedKxdBvOqLXfI1XwwnkhZ09icVWPJX0JZUBfVtKE9x 7sYtD5sknfFNX8dOoy88B1USDVw9BCoOdFr6fMOB+hmneZ/v+Wdj2RTir3IY6xDocwTAfJ4n DdngikVPugfoUyNWR04J1bD9AVj2tNsZIu5cMgsj6ZISpRYHstB7LBx9Ya1zScctTGAT2fup DiiEzqGjJcUSZUMuuvJmIR6v4toqr03yxR90yCn0eiLJOXtHGqOogAaXIGGDHGMS6KIU2hM8 CTGCAt4wggLaAgEBMDwwNTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMT DkNOUlMyLVN0YW5kYXJkAgMAsYYwDQYJYIZIAWUDBAIBBQCgggFzMBgGCSqGSIb3DQEJAzEL BgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE3MDkyMzE2NDkyOVowLwYJKoZIhvcNAQkE MSIEIHz6s56dotMl7mcmqbzPhcm6VmacYeh0EdNw9EhJZ5HqMEsGCSsGAQQBgjcQBDE+MDww NTELMAkGA1UEBhMCRlIxDTALBgNVBAoTBENOUlMxFzAVBgNVBAMTDkNOUlMyLVN0YW5kYXJk AgMAsYYwTQYLKoZIhvcNAQkQAgsxPqA8MDUxCzAJBgNVBAYTAkZSMQ0wCwYDVQQKEwRDTlJT MRcwFQYDVQQDEw5DTlJTMi1TdGFuZGFyZAIDALGGMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZI AWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZI hvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEggEAf+eJ VakTRo9fhGrvOMyrO+ey6Bs8i7ZdvNcTbwMqVZJPXZnX/qTXDm6JnIBRMMXmj7oIAdYPE+Y2 loKohgn4IPVMIGyQdY139egdT1Yw4Q7KSIFRtLFz9H9QI+D69pvnsN//2Q1Pw+UDktLOVHxx xehrT+tGAs52oCb9BGRRD29wbxoZVZT/P6xLOJiMLk/fRSeZiPp0HgCriNSREOOXRUrP9KgD WoR441CvL24ztS9fJKjHiyuD4I/6seRe32sto1Z66hp5s+Lq0qRK3p3UGSb5agcmn3sWEWY2 dF+ofg9EslTQftdtlbk3xrPYS5Qp3w2MSsNBbhIb9+kbUc/uKgAAAAAAAA== --------------ms050004020300000103070207--