Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbdIXRz2 (ORCPT ); Sun, 24 Sep 2017 13:55:28 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:38031 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624AbdIXRz1 (ORCPT ); Sun, 24 Sep 2017 13:55:27 -0400 X-Google-Smtp-Source: AOwi7QB3k3eU2FjXaReGpOy1R9opihxobbRQqeHAFopmi9REf4CT1Im77+yQ5/GeXwqcDaloVzwuLg== Date: Sun, 24 Sep 2017 18:55:25 +0100 From: Christos Gkekas To: David Howells , linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH RESEND] fs/cachefiles: Remove unnecessary comparisons in bind.c Message-ID: <20170924175525.GA4420@inspiron> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 30 cache->fstop_percent and cache->bstop_percent are unsigned so they are always >= 0. There is no point in asserting this. Signed-off-by: Christos Gkekas --- fs/cachefiles/bind.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c index d9f0010..105ac53 100644 --- a/fs/cachefiles/bind.c +++ b/fs/cachefiles/bind.c @@ -40,13 +40,11 @@ int cachefiles_daemon_bind(struct cachefiles_cache *cache, char *args) args); /* start by checking things over */ - ASSERT(cache->fstop_percent >= 0 && - cache->fstop_percent < cache->fcull_percent && + ASSERT(cache->fstop_percent < cache->fcull_percent && cache->fcull_percent < cache->frun_percent && cache->frun_percent < 100); - ASSERT(cache->bstop_percent >= 0 && - cache->bstop_percent < cache->bcull_percent && + ASSERT(cache->bstop_percent < cache->bcull_percent && cache->bcull_percent < cache->brun_percent && cache->brun_percent < 100); -- 2.7.4