Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933277AbdIXUm0 (ORCPT ); Sun, 24 Sep 2017 16:42:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60734 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbdIXUmV (ORCPT ); Sun, 24 Sep 2017 16:42:21 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Manish Rangankar , "Martin K. Petersen" Subject: [PATCH 4.13 058/109] scsi: qedi: off by one in qedi_get_cmd_from_tid() Date: Sun, 24 Sep 2017 22:33:19 +0200 Message-Id: <20170924203355.429294031@linuxfoundation.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170924203353.104695385@linuxfoundation.org> References: <20170924203353.104695385@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 34 4.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit fa2d9d6e894e096678a50ef0f65f7a8c3d8a40b8 upstream. The > here should be >= or we end up reading one element beyond the end of the qedi->itt_map[] array. The qedi->itt_map[] array is allocated in qedi_alloc_itt(). Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Signed-off-by: Dan Carpenter Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -1575,7 +1575,7 @@ struct qedi_cmd *qedi_get_cmd_from_tid(s { struct qedi_cmd *cmd = NULL; - if (tid > MAX_ISCSI_TASK_ENTRIES) + if (tid >= MAX_ISCSI_TASK_ENTRIES) return NULL; cmd = qedi->itt_map[tid].p_cmd;