Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932140AbdIXXAd (ORCPT ); Sun, 24 Sep 2017 19:00:33 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:49025 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753082AbdIXXAb (ORCPT ); Sun, 24 Sep 2017 19:00:31 -0400 X-Google-Smtp-Source: AOwi7QBvhA9nOK/tL3EGqQCM4npyIo/X3Q4LpmerDvgIl5zW3lDzwUmA4TkU/bBBqNzfCAfCV8ADXw== From: "Bryan O'Donoghue" To: srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org, richard.leitner@skidata.com, van.freenix@gmail.com, axel.lin@ingics.com, ping.bai@nxp.com, d.schultz@phytec.de, peng.fan@nxp.com Cc: "Bryan O'Donoghue" Subject: [PATCH 0/7] Fix i.MX7D OCOTP write support Date: Mon, 25 Sep 2017 00:00:21 +0100 Message-Id: <1506294028-26127-1-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1611 Lines: 38 The current OCOTP driver added support for i.MX7 read access and then added support for i.MX6 write access. Between the two commits the fact that the added write routine was only appropriate for i.MX6 was missed. As a result its certain that attempting to write i.MX7 OTP fuses on Linux would fail as the destination address on i.MX7 is different to i.MX6. Without the update to the i.MX7 setup and hold timings it's not clear that a write operation would actually do any writing which means the bad addressing on i.MX7 might not actually destroy the wrong OTP fuses, it probably would just fail to do anything, understandably I haven't experimented with knowingly bad values for one-time-programmable fuses. This series fixes the gap by: 1. Switching off OTP writing for i.MX7 2. Adding in support for the i.MX7 way of doing things 3. Switching OTP write support back on for i.MX7 There's an additional small fix for the naming of the module then to indicate it works for i.MX7 as well as for i.MX6. Tested as working on an i.MX7S WaRP7. Bryan O'Donoghure (7): nvmem: imx-ocotp: Restrict OTP write to IMX6 processors nvmem: imx-ocotp: Pass parameters via a struct nvmem: imx-ocotp: Add support for banked OTP addressing nvmem: imx-ocotp: Move i.MX6 write clock setup to dedicated function nvmem: imx-ocotp: Add i.MX7D timing write clock setup support nvmem: imx-ocotp: Enable i.MX7D OTP write support nvmem: imx-ocotp: Update module description drivers/nvmem/imx-ocotp.c | 191 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 156 insertions(+), 35 deletions(-) -- 2.7.4