Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933004AbdIXXB5 (ORCPT ); Sun, 24 Sep 2017 19:01:57 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:43329 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbdIXXAc (ORCPT ); Sun, 24 Sep 2017 19:00:32 -0400 X-Google-Smtp-Source: AOwi7QBgk4xk8bZfb7A6WDlMDAcQJeK1ov5GwxEoTlhNF0ENEbQof1LRcjYZh3/hfLU5bUPAcujIuQ== From: "Bryan O'Donoghue" To: srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org, richard.leitner@skidata.com, van.freenix@gmail.com, axel.lin@ingics.com, ping.bai@nxp.com, d.schultz@phytec.de, peng.fan@nxp.com Cc: "Bryan O'Donoghue" Subject: [PATCH 1/7] nvmem: imx-ocotp: Restrict OTP write to IMX6 processors Date: Mon, 25 Sep 2017 00:00:22 +0100 Message-Id: <1506294028-26127-2-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1506294028-26127-1-git-send-email-pure.logic@nexus-software.ie> References: <1506294028-26127-1-git-send-email-pure.logic@nexus-software.ie> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 29 i.MX7S/D have a different scheme for addressing the OTP registers inside the OCOTP block. Currently it's possible to address the wrong OTP registers given the disparity between IMX6 and IMX7 OTP addressing. Since OTP programming is one-time destructive its important we restrict this interface ASAP. Fixes: 0642bac7da42 ("nvmem: imx-ocotp: add write support") Signed-off-by: Bryan O'Donoghue --- drivers/nvmem/imx-ocotp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 193ca8f..17d160f 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -347,6 +347,8 @@ static int imx_ocotp_probe(struct platform_device *pdev) imx_ocotp_nvmem_config.dev = dev; imx_ocotp_nvmem_config.priv = priv; priv->config = &imx_ocotp_nvmem_config; + if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx7d-ocotp")) + imx_ocotp_nvmem_config.read_only = true; nvmem = nvmem_register(&imx_ocotp_nvmem_config); if (IS_ERR(nvmem)) -- 2.7.4