Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753594AbdIYEMu convert rfc822-to-8bit (ORCPT ); Mon, 25 Sep 2017 00:12:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:55310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdIYEMs (ORCPT ); Mon, 25 Sep 2017 00:12:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25184218BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: AOwi7QD9+KSngKDV/x/1tSsjdDbSbLHMEBxgoHZVvgNEULksMjFb4pTzkjGEZe769j+DbvtoEQGJXSz8M0g8y74bNFI= MIME-Version: 1.0 In-Reply-To: <1673036.ZUJy1pffid@pebbles.site> References: <20170917031956.28010-1-stefan.bruens@rwth-aachen.de> <20170917031956.28010-7-stefan.bruens@rwth-aachen.de> <20170920205300.io3ghr54kzk763kt@rob-hp-laptop> <1673036.ZUJy1pffid@pebbles.site> From: Rob Herring Date: Sun, 24 Sep 2017 23:12:26 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller To: Stefan Bruens Cc: linux-sunxi , "devicetree@vger.kernel.org" , dmaengine@vger.kernel.org, Vinod Koul , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Maxime Ripard , Chen-Yu Tsai , Code Kipper , Andre Przywara Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2185 Lines: 59 On Sat, Sep 23, 2017 at 6:34 PM, Stefan Bruens wrote: > On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote: >> On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote: >> > The A64 is register compatible with the H3, but has a different number >> > of dma channels and request ports. >> > >> > Attach additional properties to the node to allow future reuse of the >> > compatible for controllers with different number of channels/requests. >> > >> > If dma-requests is not specified, the register layout defined maximum >> > of 32 is used. >> > >> > Signed-off-by: Stefan Brüns >> > --- >> > >> > .../devicetree/bindings/dma/sun6i-dma.txt | 26 >> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+) >> > >> > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt >> > b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index >> > 98fbe1a5c6dd..6ebc79f95202 100644 >> > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt >> > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt >> > >> > @@ -27,6 +27,32 @@ Example: >> > #dma-cells = <1>; >> > >> > }; >> > >> > +------------------------------------------------------------------------- >> > ----- +For A64 DMA controller: >> > + >> > +Required properties: >> > +- compatible: "allwinner,sun50i-a64-dma" >> > +- dma-channels: Number of DMA channels supported by the controller. >> > + Refer to Documentation/devicetree/bindings/dma/dma.txt >> > +- all properties above, i.e. reg, interrupts, clocks, resets and >> > #dma-cells + >> > +Optional properties: >> > +- dma-requests: Number of DMA request signals supported by the >> > controller. >> > + Refer to Documentation/devicetree/bindings/dma/dma.txt >> > + >> > +Example: >> > + dma: dma-controller@01c02000 { >> >> Drop the leading 0. Building dtbs with W=2 will tell you this. >> >> With that, >> >> Acked-by: Rob Herring > > The leading 0 was copied from the A31 example just a few lines above. Should I > also correct that one, or should that go in a separate patch? A separate patch. Rob