Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801AbdIYFYF (ORCPT ); Mon, 25 Sep 2017 01:24:05 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37182 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753092AbdIYFYD (ORCPT ); Mon, 25 Sep 2017 01:24:03 -0400 Date: Mon, 25 Sep 2017 07:23:55 +0200 From: Martin Schwidefsky To: Himanshu Jha Cc: heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390/sclp: Use setup_timer and mod_timer In-Reply-To: <1506254414-10269-1-git-send-email-himanshujha199640@gmail.com> References: <1506254414-10269-1-git-send-email-himanshujha199640@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17092505-0040-0000-0000-000003DCBB79 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17092505-0041-0000-0000-000025DDFFCA Message-Id: <20170925072355.33e0e940@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-24_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709250086 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 33 On Sun, 24 Sep 2017 17:30:14 +0530 Himanshu Jha wrote: > Use setup_timer and mod_timer API instead of structure assignments. > > This is done using Coccinelle and semantic patch used > for this as follows: > > @@ > expression x,y,z,a,b; > @@ > > -init_timer (&x); > +setup_timer (&x, y, z); > +mod_timer (&a, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(&a); > > Signed-off-by: Himanshu Jha > --- > drivers/s390/char/sclp_con.c | 7 ++----- > drivers/s390/char/sclp_tty.c | 7 ++----- > 2 files changed, 4 insertions(+), 10 deletions(-) Added to s390/linux for the 4.15 merge window, thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.