Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbdIYGXz (ORCPT ); Mon, 25 Sep 2017 02:23:55 -0400 Received: from mout02.posteo.de ([185.67.36.66]:49412 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbdIYGXx (ORCPT ); Mon, 25 Sep 2017 02:23:53 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 25 Sep 2017 08:23:50 +0200 From: Martin Kepplinger To: Harinath Nampally Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, amsfield22@gmail.com Subject: Re: [PATCH 0/3] This patchset refactors event related functions In-Reply-To: <1506309333-1970-1-git-send-email-harinath922@gmail.com> References: <1506309333-1970-1-git-send-email-harinath922@gmail.com> Message-ID: <096ed3a299892f6f5fd92557607c2f72@posteo.de> User-Agent: Posteo Webmail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 15 Am 25.09.2017 05:15 schrieb Harinath Nampally: > Harinath Nampally (3): > Following 2 patches are for refactor: > iio: accel: mma8452: Rename time step look up struct to generic > name as the values are same for all the events. > iio: accel: mma8452: Rename read/write event value callbacks to > generic function name. > Following patch adds new feature: > iio: accel: mma8452: Add single pulse/tap event detection feature > for fxls8471. > I guess it's fine for now, but please don't call your patchset "This patchset does...". Just say "Refactor..." or whatever like you do in your patches.