Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934170AbdIYIXi (ORCPT ); Mon, 25 Sep 2017 04:23:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44560 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932617AbdIYIXf (ORCPT ); Mon, 25 Sep 2017 04:23:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EB2156025D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size From: Kalle Valo In-Reply-To: <20170922140316.12768-1-colin.king@canonical.com> References: <20170922140316.12768-1-colin.king@canonical.com> To: Colin Ian King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170925082334.DB0A860618@smtp.codeaurora.org> Date: Mon, 25 Sep 2017 08:23:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 28 Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: > text data bss dec hex filename > 39482 564 0 40046 9c6e phy_cmn.o > > After > text data bss dec hex filename > 39326 620 0 39946 9c0a phy_cmn.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. d5633bb2c62a brcmsmac: make const array ucode_ofdm_rates static, reduces object code size -- https://patchwork.kernel.org/patch/9966221/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches