Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934290AbdIYKRd (ORCPT ); Mon, 25 Sep 2017 06:17:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34066 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933186AbdIYKRb (ORCPT ); Mon, 25 Sep 2017 06:17:31 -0400 X-Google-Smtp-Source: AOwi7QACe9ud1dJ2sJO01B+KB0ZZgDIO1bjStayIDq4y6/NEocS2PktfXRtsGo7RYUua07Qb4UAw2g5VUlXYFKhJYaA= MIME-Version: 1.0 In-Reply-To: <5d8c841101a35b47aec56cef1b5a3ff1@posteo.de> References: <1506334065-2891-1-git-send-email-harinath922@gmail.com> <5d8c841101a35b47aec56cef1b5a3ff1@posteo.de> From: harinath Nampally Date: Mon, 25 Sep 2017 06:16:49 -0400 Message-ID: Subject: Re: [PATCH 0/3] Refactor event related code To: Martin Kepplinger Cc: Jonathan Cameron , knaack.h@gmx.de, lars@metafoo.de, Peter Meerwald-Stadler , Greg KH , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Alison Schofield Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 33 > First, this is at least v2 of this series. Second, it still seems to include > a 4th unrelated patch. ok I was not sure whether to make it v2 as the change was to only cover letter and no code changes. But now I know, will send v3 of this series. > It's sometimes not trivial to get email right. Why not test sending it privately > to yourself first? Sure will do, sorry for the convenience. Thanks, Harinath On Mon, Sep 25, 2017 at 6:11 AM, Martin Kepplinger wrote: > Am 25.09.2017 12:07 schrieb Harinath Nampally: >> >> Rename some struct names and function names to >> improve code readability. >> >> Harinath Nampally (3): >> iio: accel: mma8452: Rename structs holding event configuration >> registers to more appropriate names. >> iio: accel: mma8452: Rename time step look up struct to generic >> name as the values are same for all the events. >> iio: accel: mma8452: Rename read/write event value callbacks to >> generic function name. >> > > First, this is at least v2 of this series. Second, it still seems to include > a 4th unrelated patch. > > It's sometimes not trivial to get email right. Why not test sending it > privately > to yourself first?