Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934842AbdIYK5w (ORCPT ); Mon, 25 Sep 2017 06:57:52 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:37508 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934668AbdIYK5u (ORCPT ); Mon, 25 Sep 2017 06:57:50 -0400 X-Google-Smtp-Source: AOwi7QCsDdFTgfn3CvPdTAp159RMV0g7pdkS+kGTltPwv0+GcbvJvfhBxqGb0Zq9xnVPEe580HLTE8BEJdc2weGdttU= MIME-Version: 1.0 In-Reply-To: <20170922234543.GB20327@fury> References: <20170917225712.12136-1-jerome.debretagne@gmail.com> <20170922234543.GB20327@fury> From: Andy Shevchenko Date: Mon, 25 Sep 2017 13:57:48 +0300 Message-ID: Subject: Re: [PATCH] platform/x86: intel-hid: Power button suspend on Dell Latitude 7275 To: Darren Hart Cc: =?UTF-8?B?SsOpcsO0bWUgZGUgQnJldGFnbmU=?= , Platform Driver , LKML , Linux ACPI , "Rafael J. Wysocki" , Mario Limonciello , Alex Hung Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8PAvuUN027633 Content-Length: 817 Lines: 25 On Sat, Sep 23, 2017 at 2:45 AM, Darren Hart wrote: > On Mon, Sep 18, 2017 at 12:57:12AM +0200, Jérôme de Bretagne wrote: >> + if (event == 0xce) { >> + input_report_key(priv->input_dev, KEY_POWER, 1); >> + input_sync(priv->input_dev); >> + return; >> + } else if (event == 0xcf) >> + return; > > Minor CodingStyle nit. If the if block uses parens, so does the else block. In > this case, since the if returns, just skip the else entirely. > > See Documentation/process/coding-style.rst > The example immediatley *before* 3.1) Spaces. > > I've made this change and queued for testing. > >> + } Actually in this case even 'else' is redundant. -- With Best Regards, Andy Shevchenko