Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934405AbdIYMWv (ORCPT ); Mon, 25 Sep 2017 08:22:51 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42044 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932656AbdIYMWt (ORCPT ); Mon, 25 Sep 2017 08:22:49 -0400 Date: Mon, 25 Sep 2017 14:22:19 +0200 From: Peter Zijlstra To: Laurent Dufour Cc: Sergey Senozhatsky , paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v3 04/20] mm: VMA sequence count Message-ID: <20170925122219.ia6cmz2tng65fhoe@hirez.programming.kicks-ass.net> References: <20170913115354.GA7756@jagdpanzerIV.localdomain> <44849c10-bc67-b55e-5788-d3c6bb5e7ad1@linux.vnet.ibm.com> <20170914003116.GA599@jagdpanzerIV.localdomain> <441ff1c6-72a7-5d96-02c8-063578affb62@linux.vnet.ibm.com> <20170914081358.GG599@jagdpanzerIV.localdomain> <26fa0b71-4053-5af7-baa0-e5fff9babf41@linux.vnet.ibm.com> <20170914091101.GH599@jagdpanzerIV.localdomain> <9605ce43-0f61-48d7-88e2-88220b773494@linux.vnet.ibm.com> <20170914094043.GJ599@jagdpanzerIV.localdomain> <4e6c4e45-bbd6-3fd8-ee96-216892c797b3@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e6c4e45-bbd6-3fd8-ee96-216892c797b3@linux.vnet.ibm.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 14 On Fri, Sep 15, 2017 at 02:38:51PM +0200, Laurent Dufour wrote: > > /* > > * well... answering your question - it seems raw versions of seqcount > > * functions don't call lockdep's lock_acquire/lock_release... > > * > > * but I have never told you that. never. > > */ > > Hum... I'm not sure that would be the best way since in other case lockdep > checks are valid, but if getting rid of locked's warning is required to get > this series upstream, I'd use raw versions... Please advice... No sensible other way to shut it up come to mind though. Might be best to use the raw primitives with a comment explaining why.