Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269814AbTGKIN4 (ORCPT ); Fri, 11 Jul 2003 04:13:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269816AbTGKIN4 (ORCPT ); Fri, 11 Jul 2003 04:13:56 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:3810 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S269814AbTGKINi (ORCPT ); Fri, 11 Jul 2003 04:13:38 -0400 Date: Fri, 11 Jul 2003 10:28:17 +0200 From: Jens Axboe To: Ivan Gyurdiev Cc: LKML , Bartlomiej Zolnierkiewicz Subject: Re: 2.5.75 does not boot - TCQ oops Message-ID: <20030711082817.GE843@suse.de> References: <200307102251.42787.ivg2@cornell.edu> <20030711080335.GD843@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030711080335.GD843@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1674 Lines: 55 On Fri, Jul 11 2003, Jens Axboe wrote: > On Thu, Jul 10 2003, Ivan Gyurdiev wrote: > > See, > > > > http://www.ussg.iu.edu/hypermail/linux/kernel/0307.0/0515.html > > > > where the bug is described for 2.5.74. > > I got no replies, and the bug persists in 2.5.75 (+bk patches). > > > > Note: > > The machine boots with TASKFILE on, TCQ is causing the problem. > > Looks like IDE using the queue before it has been setup, probably Bart > broke it when he moved the TCQ init around. I'll take a look. Here's the fix. Bart, you moved the tcq init to a much earlier fase (saying ide_init_drive() was too early, well ide_dma_on is much earlier in the init fase). ide_init_drive() _is_ the correct location in my oppinion, drive and queue has been set up at this point. --- drivers/ide/ide-dma.c~ 2003-07-11 10:21:04.492561920 +0200 +++ drivers/ide/ide-dma.c 2003-07-11 10:25:28.183474808 +0200 @@ -572,10 +572,6 @@ if (HWIF(drive)->ide_dma_host_on(drive)) return 1; -#ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT - HWIF(drive)->ide_dma_queued_on(drive); -#endif - return 0; } --- drivers/ide/ide-probe.c~ 2003-07-11 10:06:54.036850840 +0200 +++ drivers/ide/ide-probe.c 2003-07-11 10:25:30.884064256 +0200 @@ -945,6 +945,10 @@ static void ide_init_drive(ide_drive_t *drive) { ide_toggle_bounce(drive, 1); + +#ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT + HWIF(drive)->ide_dma_queued_on(drive); +#endif } /* -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/