Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965425AbdIYXLx (ORCPT ); Mon, 25 Sep 2017 19:11:53 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:46752 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934254AbdIYXLu (ORCPT ); Mon, 25 Sep 2017 19:11:50 -0400 X-Google-Smtp-Source: AOwi7QCDUZ5xDLjbQFZL28EliFtdqhg0SoESdH+IHeeAId3lCzktXch7E4S0UYSXtV/tweTZQRtEyA== Date: Mon, 25 Sep 2017 16:11:48 -0700 From: Viresh Kumar To: Arvind Yadav Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines Message-ID: <20170925231148.GB3053@ubuntu> References: <113fdc7d136811950c78a7cb2f11f9d98eeb26dc.1506332261.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <113fdc7d136811950c78a7cb2f11f9d98eeb26dc.1506332261.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 26 On 25-09-17, 15:10, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. > > Signed-off-by: Arvind Yadav > --- > drivers/cpufreq/powernow-k8.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c > index 062d714..b01e31d 100644 > --- a/drivers/cpufreq/powernow-k8.c > +++ b/drivers/cpufreq/powernow-k8.c > @@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol) > > data = kzalloc(sizeof(*data), GFP_KERNEL); > if (!data) { > - pr_err("unable to alloc powernow_k8_data"); > + pr_err("unable to alloc powernow_k8_data\n"); > return -ENOMEM; > } Acked-by: Viresh Kumar -- viresh