Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965467AbdIYXMF (ORCPT ); Mon, 25 Sep 2017 19:12:05 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:56958 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965437AbdIYXMC (ORCPT ); Mon, 25 Sep 2017 19:12:02 -0400 X-Google-Smtp-Source: AOwi7QA8Btgkf7TOtm02xtsIzwuLKfEI6JSbJPKSJ6jjxdqelBgrcvA5N6Hp1rbTHpK/TQPK8k5c7Q== Date: Mon, 25 Sep 2017 16:12:00 -0700 From: Viresh Kumar To: Arvind Yadav Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines Message-ID: <20170925231200.GC3053@ubuntu> References: <511e2c0f9a2dd23aceb8c0fc39184bfaca1f98c9.1506334381.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <511e2c0f9a2dd23aceb8c0fc39184bfaca1f98c9.1506334381.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 36 On 25-09-17, 15:43, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. > > Signed-off-by: Arvind Yadav > --- > drivers/cpufreq/spear-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 4894924..195f27f 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -177,7 +177,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev) > > np = of_cpu_device_node_get(0); > if (!np) { > - pr_err("No cpu node found"); > + pr_err("No cpu node found\n"); > return -ENODEV; > } > > @@ -187,7 +187,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev) > > prop = of_find_property(np, "cpufreq_tbl", NULL); > if (!prop || !prop->value) { > - pr_err("Invalid cpufreq_tbl"); > + pr_err("Invalid cpufreq_tbl\n"); > ret = -ENODEV; > goto out_put_node; > } Acked-by: Viresh Kumar -- viresh