Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966389AbdIYXYw (ORCPT ); Mon, 25 Sep 2017 19:24:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35076 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966230AbdIYXYv (ORCPT ); Mon, 25 Sep 2017 19:24:51 -0400 Date: Mon, 25 Sep 2017 16:24:45 -0700 (PDT) Message-Id: <20170925.162445.234890912211240693.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: kuznet@ms2.inr.ac.ru, edumazet@google.com, weiwan@google.com, lucab@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob From: David Miller In-Reply-To: <1506088124-12650-2-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1506088124-12650-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1506088124-12650-2-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Sep 2017 16:24:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 447 Lines: 15 From: Haishuang Yan Date: Fri, 22 Sep 2017 21:48:43 +0800 > @@ -9,13 +9,18 @@ > #include > #include > > -struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; > - > -static DEFINE_SPINLOCK(tcp_fastopen_ctx_lock); > - > -void tcp_fastopen_init_key_once(bool publish) > +void tcp_fastopen_init_key_once(struct net *net) Why did you remove the 'publish' logic from this function?