Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966135AbdIYXXT (ORCPT ); Mon, 25 Sep 2017 19:23:19 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47742 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965731AbdIYXXS (ORCPT ); Mon, 25 Sep 2017 19:23:18 -0400 To: Meng Xu Cc: hch@infradead.org, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, meng.xu@gatech.edu, sanidhya@gatech.edu, taesoo@gatech.edu Subject: Re: [PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo From: "Martin K. Petersen" Organization: Oracle Corporation References: <1505920431-13173-1-git-send-email-mengxu.gatech@gmail.com> Date: Mon, 25 Sep 2017 19:22:35 -0400 In-Reply-To: <1505920431-13173-1-git-send-email-mengxu.gatech@gmail.com> (Meng Xu's message of "Wed, 20 Sep 2017 11:13:51 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 214 Lines: 10 Meng, > Since right after the user copy, we are going to > memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering