Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966996AbdIZBhb (ORCPT ); Mon, 25 Sep 2017 21:37:31 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35471 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965729AbdIZBh3 (ORCPT ); Mon, 25 Sep 2017 21:37:29 -0400 X-Google-Smtp-Source: AOwi7QCyw+oPCBrVapYwDHGQsUvgt6h4JT0XCRAfvuwrUAZtyX1ZgJjVrkBtht5FoxrsTcjJ5A/U7OLvbp5aGTuAHyU= MIME-Version: 1.0 In-Reply-To: <20170926010036.GX32076@ZenIV.linux.org.uk> References: <20170926010036.GX32076@ZenIV.linux.org.uk> From: Linus Torvalds Date: Mon, 25 Sep 2017 18:37:28 -0700 X-Google-Sender-Auth: FDiUh76jaDNKz8lPiuj4rJD5TOg Message-ID: Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat To: Al Viro Cc: Kyle Huey , open list , "Robert O'Callahan" Content-Type: multipart/mixed; boundary="001a113eb1ccd7dd98055a0db755" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4224 Lines: 72 --001a113eb1ccd7dd98055a0db755 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 25, 2017 at 6:00 PM, Al Viro wrote: > > I really wish gcc warned about conversions from pointer to function into > void *... Pulled and pushed out, but I'd like to note that sparse would have caught this. Except we are so far away from being sparse-clean that nobody runs it. And I think your recent compat cleanup work actually made it worse, showing new warnings (including the one that was a real bug) Oh well. Patch to at least fix the address space warnings in ipc/ attached. Linus --001a113eb1ccd7dd98055a0db755 Content-Type: text/plain; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j80xm18n0 IGlwYy9tc2cuYyAgICAgfCA0ICsrLS0KIGlwYy9zZW0uYyAgICAgfCA0ICsrLS0KIGlwYy9zaG0u YyAgICAgfCA0ICsrLS0KIGlwYy9zeXNjYWxsLmMgfCAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDcg aW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9pcGMvbXNnLmMgYi9p cGMvbXNnLmMKaW5kZXggMDZiZTVhOWFkZmE0Li5lYmI3ZWEyNGVlMjggMTAwNjQ0Ci0tLSBhL2lw Yy9tc2cuYworKysgYi9pcGMvbXNnLmMKQEAgLTU5MCwxMyArNTkwLDEzIEBAIHN0YXRpYyBpbnQg Y29weV9jb21wYXRfbXNxaWRfZnJvbV91c2VyKHN0cnVjdCBtc3FpZDY0X2RzICpvdXQsIHZvaWQg X191c2VyICpidWYsCiB7CiAJbWVtc2V0KG91dCwgMCwgc2l6ZW9mKCpvdXQpKTsKIAlpZiAodmVy c2lvbiA9PSBJUENfNjQpIHsKLQkJc3RydWN0IGNvbXBhdF9tc3FpZDY0X2RzICpwID0gYnVmOwor CQlzdHJ1Y3QgY29tcGF0X21zcWlkNjRfZHMgX191c2VyICpwID0gYnVmOwogCQlpZiAoZ2V0X2Nv bXBhdF9pcGM2NF9wZXJtKCZvdXQtPm1zZ19wZXJtLCAmcC0+bXNnX3Blcm0pKQogCQkJcmV0dXJu IC1FRkFVTFQ7CiAJCWlmIChnZXRfdXNlcihvdXQtPm1zZ19xYnl0ZXMsICZwLT5tc2dfcWJ5dGVz KSkKIAkJCXJldHVybiAtRUZBVUxUOwogCX0gZWxzZSB7Ci0JCXN0cnVjdCBjb21wYXRfbXNxaWRf ZHMgKnAgPSBidWY7CisJCXN0cnVjdCBjb21wYXRfbXNxaWRfZHMgX191c2VyICpwID0gYnVmOwog CQlpZiAoZ2V0X2NvbXBhdF9pcGNfcGVybSgmb3V0LT5tc2dfcGVybSwgJnAtPm1zZ19wZXJtKSkK IAkJCXJldHVybiAtRUZBVUxUOwogCQlpZiAoZ2V0X3VzZXIob3V0LT5tc2dfcWJ5dGVzLCAmcC0+ bXNnX3FieXRlcykpCmRpZmYgLS1naXQgYS9pcGMvc2VtLmMgYi9pcGMvc2VtLmMKaW5kZXggZjcz ODViY2U1ZmQzLi42MjIwZTk2MTYyMDcgMTAwNjQ0Ci0tLSBhL2lwYy9zZW0uYworKysgYi9pcGMv c2VtLmMKQEAgLTE2MzYsMTAgKzE2MzYsMTAgQEAgc3RhdGljIGludCBjb3B5X2NvbXBhdF9zZW1p ZF9mcm9tX3VzZXIoc3RydWN0IHNlbWlkNjRfZHMgKm91dCwgdm9pZCBfX3VzZXIgKmJ1ZiwKIHsK IAltZW1zZXQob3V0LCAwLCBzaXplb2YoKm91dCkpOwogCWlmICh2ZXJzaW9uID09IElQQ182NCkg ewotCQlzdHJ1Y3QgY29tcGF0X3NlbWlkNjRfZHMgKnAgPSBidWY7CisJCXN0cnVjdCBjb21wYXRf c2VtaWQ2NF9kcyBfX3VzZXIgKnAgPSBidWY7CiAJCXJldHVybiBnZXRfY29tcGF0X2lwYzY0X3Bl cm0oJm91dC0+c2VtX3Blcm0sICZwLT5zZW1fcGVybSk7CiAJfSBlbHNlIHsKLQkJc3RydWN0IGNv bXBhdF9zZW1pZF9kcyAqcCA9IGJ1ZjsKKwkJc3RydWN0IGNvbXBhdF9zZW1pZF9kcyBfX3VzZXIg KnAgPSBidWY7CiAJCXJldHVybiBnZXRfY29tcGF0X2lwY19wZXJtKCZvdXQtPnNlbV9wZXJtLCAm cC0+c2VtX3Blcm0pOwogCX0KIH0KZGlmZiAtLWdpdCBhL2lwYy9zaG0uYyBiL2lwYy9zaG0uYwpp bmRleCBiYWRhYzQ2M2UyYzguLjg1NDI4YjA5NGRmOSAxMDA2NDQKLS0tIGEvaXBjL3NobS5jCisr KyBiL2lwYy9zaG0uYwpAQCAtMTE5MywxMCArMTE5MywxMCBAQCBzdGF0aWMgaW50IGNvcHlfY29t cGF0X3NobWlkX2Zyb21fdXNlcihzdHJ1Y3Qgc2htaWQ2NF9kcyAqb3V0LCB2b2lkIF9fdXNlciAq YnVmLAogewogCW1lbXNldChvdXQsIDAsIHNpemVvZigqb3V0KSk7CiAJaWYgKHZlcnNpb24gPT0g SVBDXzY0KSB7Ci0JCXN0cnVjdCBjb21wYXRfc2htaWQ2NF9kcyAqcCA9IGJ1ZjsKKwkJc3RydWN0 IGNvbXBhdF9zaG1pZDY0X2RzIF9fdXNlciAqcCA9IGJ1ZjsKIAkJcmV0dXJuIGdldF9jb21wYXRf aXBjNjRfcGVybSgmb3V0LT5zaG1fcGVybSwgJnAtPnNobV9wZXJtKTsKIAl9IGVsc2UgewotCQlz dHJ1Y3QgY29tcGF0X3NobWlkX2RzICpwID0gYnVmOworCQlzdHJ1Y3QgY29tcGF0X3NobWlkX2Rz IF9fdXNlciAqcCA9IGJ1ZjsKIAkJcmV0dXJuIGdldF9jb21wYXRfaXBjX3Blcm0oJm91dC0+c2ht X3Blcm0sICZwLT5zaG1fcGVybSk7CiAJfQogfQpkaWZmIC0tZ2l0IGEvaXBjL3N5c2NhbGwuYyBi L2lwYy9zeXNjYWxsLmMKaW5kZXggNjY3MDIyNzQ2Y2E1Li45NzdiZmZkNWE3ZjggMTAwNjQ0Ci0t LSBhL2lwYy9zeXNjYWxsLmMKKysrIGIvaXBjL3N5c2NhbGwuYwpAQCAtMTcxLDcgKzE3MSw3IEBA IENPTVBBVF9TWVNDQUxMX0RFRklORTYoaXBjLCB1MzIsIGNhbGwsIGludCwgZmlyc3QsIGludCwg c2Vjb25kLAogCQkJICAgICAgIENPTVBBVF9TSE1MQkEpOwogCQlpZiAoZXJyIDwgMCkKIAkJCXJl dHVybiBlcnI7Ci0JCXJldHVybiBwdXRfdXNlcihyYWRkciwgKGNvbXBhdF91bG9uZ190ICopY29t cGF0X3B0cih0aGlyZCkpOworCQlyZXR1cm4gcHV0X3VzZXIocmFkZHIsIChjb21wYXRfdWxvbmdf dCBfX3VzZXIgKiljb21wYXRfcHRyKHRoaXJkKSk7CiAJfQogCWNhc2UgU0hNRFQ6CiAJCXJldHVy biBzeXNfc2htZHQoY29tcGF0X3B0cihwdHIpKTsK --001a113eb1ccd7dd98055a0db755--