Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967050AbdIZCAz (ORCPT ); Mon, 25 Sep 2017 22:00:55 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:52820 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965697AbdIZCAy (ORCPT ); Mon, 25 Sep 2017 22:00:54 -0400 Date: Tue, 26 Sep 2017 03:00:48 +0100 From: Al Viro To: Linus Torvalds Cc: Kyle Huey , open list , "Robert O'Callahan" Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat Message-ID: <20170926020047.GZ32076@ZenIV.linux.org.uk> References: <20170926010036.GX32076@ZenIV.linux.org.uk> <20170926014656.GY32076@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170926014656.GY32076@ZenIV.linux.org.uk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 18 On Tue, Sep 26, 2017 at 02:46:56AM +0100, Al Viro wrote: > On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote: > > > And I think your recent compat cleanup work actually made it worse, > > showing new warnings (including the one that was a real bug) > > Actually, they are not new - try make C=2 ipc/compat.o on v4.13 and you'll > see their previous locations. > > > Patch to at least fix the address space warnings in ipc/ attached. > > Which tree do you prefer it to go through? Direct to mainline, or vfs.git > #for-next? FWIW, __percpu and __rcu annotations are messy as hell. Never got around to sorting down the infrastructure annotations for that bunch, and I'm not entirely sure that they (especially __rcu) are a good match for __address_space__(()).