Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966126AbdIZCHE (ORCPT ); Mon, 25 Sep 2017 22:07:04 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33229 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934681AbdIZCHC (ORCPT ); Mon, 25 Sep 2017 22:07:02 -0400 X-Google-Smtp-Source: AOwi7QAZMwX3Z0Ea9maZThzNx2HrmW6e/iLRJj6bMynIXwYrpta8HKuWxanOIW4oLPBAfWzEoGs7bvbWgWo9I+7PUB8= MIME-Version: 1.0 In-Reply-To: References: <20170926010036.GX32076@ZenIV.linux.org.uk> <20170926014656.GY32076@ZenIV.linux.org.uk> <20170926020047.GZ32076@ZenIV.linux.org.uk> From: Linus Torvalds Date: Mon, 25 Sep 2017 19:07:01 -0700 X-Google-Sender-Auth: YNzDCIsM8xHx-ACkY2M202C26hg Message-ID: Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat To: Al Viro Cc: Kyle Huey , open list , "Robert O'Callahan" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 22 On Mon, Sep 25, 2017 at 7:03 PM, Linus Torvalds wrote: > > I agree. It might be better to just remove the address space logic, > because afaik it never worked for them. .. and sadly, we should probably disable the locking ones by default too, because while they *work*, sparse only handles static cases, and we have way too many dynamically conditional cases that are outside the scope of what sparse does. It would probably be good to disable things that are fundamentally hard to fix, and aim for a clean sparse build, and maybe people would start using it at least for user pointer checking where it really does work. Of course, even there it depends on pointers _statically_ being user pointers, but happily we do largely follow that rule. We've had a few nasty cases where we have a pointer that is conditionally user or kernel pointer, but they are thankfully pretty rare. Linus