Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S964873AbdIZDHo (ORCPT <rfc822;w@1wt.eu>);
        Mon, 25 Sep 2017 23:07:44 -0400
Received: from mail-oi0-f45.google.com ([209.85.218.45]:53996 "EHLO
        mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752295AbdIZDHm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 Sep 2017 23:07:42 -0400
X-Google-Smtp-Source: AOwi7QDFYLGKnPlBCCEHqTLqpYyhlet2DTqFWZQcfHLH2SdyQREg6vAHmd1FPtX14KNf2biqfBJQOGKRz+81so4A368=
MIME-Version: 1.0
From: Nick Desaulniers <nick.desaulniers@gmail.com>
Date: Mon, 25 Sep 2017 20:07:41 -0700
Message-ID: <CAH7mPvis=5FvWXYFhasR+Rqw+hezZnN6ME_PHTa1utQ7iT0aOA@mail.gmail.com>
Subject: unneeded internal declaration
To: josh@joshtriplett.org, Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: kay@vrfy.org, avi@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 526
Lines: 12

today I noticed I was getting the warning:

arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed
and will not be emitted [-Wunneeded-internal-declaration]

seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX:
Auto-load on CPUs with VMX"

seems like other call sites of the MODULE_DEVICE_TABLE typically get
added to an id_table of various driver structs.  Should that be the
case here, or would a `__unused` modifier be a way forward (if so,
please confirm, would be a good first bug for a friend)?