Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966267AbdIZDfs (ORCPT ); Mon, 25 Sep 2017 23:35:48 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39575 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933685AbdIZDfq (ORCPT ); Mon, 25 Sep 2017 23:35:46 -0400 X-Originating-IP: 50.39.160.18 Date: Mon, 25 Sep 2017 20:35:39 -0700 From: Josh Triplett To: Nick Desaulniers Cc: Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , kay@vrfy.org, avi@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: unneeded internal declaration Message-ID: <20170926033539.hxwrjjpqeadkj4ky@x> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 17 On Mon, Sep 25, 2017 at 08:07:41PM -0700, Nick Desaulniers wrote: > today I noticed I was getting the warning: > > arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed > and will not be emitted [-Wunneeded-internal-declaration] > > seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX: > Auto-load on CPUs with VMX" > > seems like other call sites of the MODULE_DEVICE_TABLE typically get > added to an id_table of various driver structs. Should that be the > case here, or would a `__unused` modifier be a way forward (if so, > please confirm, would be a good first bug for a friend)? Many of those users seem to have an x86_match_cpu call in their init function. vmx has its own checks; perhaps it'd make sense to use that instead, which would also eliminate the warning?